fix hanging goroutine

2024-01-26 16:27:16 +08:00
parent 03539164e5
commit 86f4adca3f
1 changed files with 57 additions and 51 deletions
--- a/pkg/impl/signal-server/signaling.go
+++ b/pkg/impl/signal-server/signaling.go
@ -119,7 +119,12 @@ func (signalingServer SignalingServer) handleRedisPubSub(ctx context.Context, na
 		}

 		ch := pubsub.Channel()
-		for msg := range ch {
+		for {
+			select {
+			case <-ctx.Done():
+				return nil
+			case msg := <-ch:
+
 				switch msg.Channel {
 				case signalingServer.redisKeyPrefix + ":" + room + ":discover":
 					if err := stream.Send(&proto.SignalingMessage{
@ -175,6 +180,7 @@ func (signalingServer SignalingServer) handleRedisPubSub(ctx context.Context, na
 					}
 				}
 			}
+		}

 		return nil
 	}